inspector: Fix Coverty scan errors#7324
Closed
eugeneo wants to merge 1 commit intonodejs:masterfrom
eugeneo:coverty
Closed
inspector: Fix Coverty scan errors#7324eugeneo wants to merge 1 commit intonodejs:masterfrom eugeneo:coverty
eugeneo wants to merge 1 commit intonodejs:masterfrom
eugeneo:coverty
Conversation
nodejs-github-bot
added
the
c++
Contributor
Contributor
|
LGTM. The CI is green. |
Member
|
LGTM The ASSERT_EQ a few lines up should probably be a CHECK_EQ. The buffer is filled with whatever is on the stack if |
Contributor
Author
|
@bnoordhuis I'm now setting target title to a default value if the call fails. |
src/inspector_agent.cc
Outdated
Member
There was a problem hiding this comment.
Can you use snprintf()? Most static analysis tools will complain about strcpy() (even if it's harmless here.)
Member
|
LGTM with a comment. |
Contributor
|
New CI https://ci.nodejs.org/job/node-test-pull-request/3015/ is green. |
ofrobots
pushed a commit
that referenced
this pull request
Jun 17, 2016
PR-URL: #7324 Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com> Reviewed-By: ofrobots - Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Contributor
|
Landed as dfcf02b. |
Fishrock123
pushed a commit
that referenced
this pull request
Jul 5, 2016
PR-URL: #7324 Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com> Reviewed-By: ofrobots - Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX) orvcbuild test nosign(Windows) passesAffected core subsystem(s)
This touches inspector
Description of change
Fix a bug detected by Coverty.
CC: @ofrobots